brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

power: Label the PENDING_CHARGE state as "Not Charging"

Browse Source 
The pending-charge state means AC power is on but the battery is not
being charged. This can happen because its charge is above a certain
threshold, to avoid short charging cycles and prolong the battery's
life, or because the PSU is not powerful enough to charge the batteries.

Instead of lying to the user about something being estimated, we should
simply tell the truth and set the label to "Not Charging".

Closes: #701.
This commit is contained in:
João Paulo Rechi Vita 2018-11-02 13:51:33 -07:00
parent 240f3faf6e
commit 52c59ac0dd
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/status/power.js
View File

@ -70,7 +70,9 @@ var Indicator = new Lang.Class({
seconds = this._proxy.TimeToFull;
else if (this._proxy.State == UPower.DeviceState.DISCHARGING)
seconds = this._proxy.TimeToEmpty;
// state is one of PENDING_CHARGING, PENDING_DISCHARGING
else if (this._proxy.State == UPower.DeviceState.PENDING_CHARGE)
return _("Not Charging");
// state is PENDING_DISCHARGE
else
return _("Estimating…");