From 51b7eb7a2b93f7a13440b95712152f5ca335927d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= Date: Mon, 27 Jan 2020 23:42:28 +0100 Subject: [PATCH] altTab: Don't fade out thumbnails on destroy The thumbnails actor `this._thumbnails` has already been destroyed when calling `_destroyThumbnails()` from the `destroy` signal handler because it is a child actor of the AppSwitcherPopup. So stop destroying the thumbnails separately (fading them out inside a destroy handler wouldn't make sense anyway). https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/167 --- js/ui/altTab.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/js/ui/altTab.js b/js/ui/altTab.js index 35d991e20..94b80f792 100644 --- a/js/ui/altTab.js +++ b/js/ui/altTab.js @@ -280,12 +280,10 @@ class AppSwitcherPopup extends SwitcherPopup.SwitcherPopup { } _onDestroy() { - super._onDestroy(); - - if (this._thumbnails) - this._destroyThumbnails(); if (this._thumbnailTimeoutId != 0) GLib.source_remove(this._thumbnailTimeoutId); + + super._onDestroy(); } /**