From 51537cf31c7f6589635852629bd7f0549175515e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 28 Jul 2020 18:52:53 +0200 Subject: [PATCH] panelMenu: Destroy menu before chaining up This avoid some (harmless but annoying) warnings, and is closer to the original code prior to commit fc342fe8c5 and 557b232c896. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3022 --- js/ui/panelMenu.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/js/ui/panelMenu.js b/js/ui/panelMenu.js index a5b0896c4..274daa7ea 100644 --- a/js/ui/panelMenu.js +++ b/js/ui/panelMenu.js @@ -183,10 +183,9 @@ var Button = GObject.registerClass({ } _onDestroy() { - super._onDestroy(); - if (this.menu) this.menu.destroy(); + super._onDestroy(); } });