brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspace: Properly handle zero spacing in the WorkspaceLayout

Browse Source 
It should be allowed to set this._spacing to 0 and thus pass 0 as
rowSpacing or colSpacing to this._adjustSpacingAndPadding(). The current
if-condition there won't add the oversize to the spacing in case 0 is
passed though.

So change that if-condition and explicitely check for null instead.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1698>
This commit is contained in:
Jonas Dreßler 2021-02-08 18:58:27 +01:00
parent adc5f2d81f
commit 51348c6020
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/workspace.js
View File

@ -463,9 +463,9 @@ var WorkspaceLayout = GObject.registerClass({
const [topOversize, bottomOversize] = window.chromeHeights(); const [topOversize, bottomOversize] = window.chromeHeights();
const [leftOversize, rightOversize] = window.chromeWidths(); const [leftOversize, rightOversize] = window.chromeWidths();
if (rowSpacing) if (rowSpacing !== null)
rowSpacing += topOversize + bottomOversize; rowSpacing += topOversize + bottomOversize;
if (colSpacing) if (colSpacing !== null)
colSpacing += Math.max(leftOversize, rightOversize); colSpacing += Math.max(leftOversize, rightOversize);
if (containerBox) { if (containerBox) {