From 4f66b301e7027f66233914bfa993bedcbbd3abaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 17 Dec 2019 01:00:40 +0100 Subject: [PATCH] panel: Disable menu-toggle shortcuts while top bar is hidden We currently handle the case where the indicator itself is disabled (read: hidden), but not when the entire top bar is invisible (for instance when the primary monitor is in fullscreen state). It is odd to pop up a top bar menu without the top bar, so check for the indicator's mapped- instead of visible state. https://gitlab.gnome.org/GNOME/gnome-shell/issues/2002 --- js/ui/panel.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/panel.js b/js/ui/panel.js index 73002d039..80e6179b6 100644 --- a/js/ui/panel.js +++ b/js/ui/panel.js @@ -962,7 +962,7 @@ class Panel extends St.Widget { } _toggleMenu(indicator) { - if (!indicator || !indicator.container.visible) + if (!indicator || !indicator.mapped) return; // menu not supported by current session mode let menu = indicator.menu;