brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspaceThumbnails: Immediately initialize should-show

Browse Source 
At the moment, we only get the initial :should-show value when populating
the thumbnails. That only happens when entering the overview, so any
listeners to notify::should-show will perceive it as a change rather
than an initialization, which can result in unwanted transitions.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1735>
This commit is contained in:
Florian Müllner 2021-02-21 00:23:07 +01:00 committed by Marge Bot
parent 09afaf0745
commit 4eb31e4e18
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/ui/workspaceThumbnail.js
View File

@ -684,6 +684,7 @@ var ThumbnailsBox = GObject.registerClass({
this._settings = new Gio.Settings({ schema_id: MUTTER_SCHEMA }); this._settings = new Gio.Settings({ schema_id: MUTTER_SCHEMA });
this._settings.connect('changed::dynamic-workspaces', this._settings.connect('changed::dynamic-workspaces',
() => this._updateShouldShow()); () => this._updateShouldShow());
this._updateShouldShow();
this._monitorsChangedId = this._monitorsChangedId =
Main.layoutManager.connect('monitors-changed', () => { Main.layoutManager.connect('monitors-changed', () => {
@ -1010,8 +1011,6 @@ var ThumbnailsBox = GObject.registerClass({
this._stateCounts[ThumbnailState[key]] = 0; this._stateCounts[ThumbnailState[key]] = 0;
this.addThumbnails(0, workspaceManager.n_workspaces); this.addThumbnails(0, workspaceManager.n_workspaces);
this._updateShouldShow();
} }
_destroyThumbnails() { _destroyThumbnails() {