Drop use of libgsystem, move single API call into shell-global.c
See https://mail.gnome.org/archives/desktop-devel-list/2015-February/msg00121.html We presently only indirectly link to it via this one call; until GLib gains structured logging, simply import the code to wrap the journal logging in an introspectable API into Shell. https://bugzilla.gnome.org/show_bug.cgi?id=744457
This commit is contained in:
parent
ea66329423
commit
4da7f20759
@ -218,16 +218,10 @@ function _initializeUI() {
|
|||||||
if (screenShield) {
|
if (screenShield) {
|
||||||
screenShield.lockIfWasLocked();
|
screenShield.lockIfWasLocked();
|
||||||
}
|
}
|
||||||
if (LoginManager.haveSystemd() &&
|
if (sessionMode.currentMode != 'gdm' &&
|
||||||
sessionMode.currentMode != 'gdm' &&
|
|
||||||
sessionMode.currentMode != 'initial-setup') {
|
sessionMode.currentMode != 'initial-setup') {
|
||||||
// Do not import globally to not depend
|
Shell.log_structured_print('GNOME Shell started at ' + _startDate,
|
||||||
// on systemd on non-systemd systems.
|
['MESSAGE_ID=' + GNOMESHELL_STARTED_MESSAGE_ID]);
|
||||||
let GSystem = imports.gi.GSystem;
|
|
||||||
GSystem.log_structured_print('GNOME Shell started at ' + _startDate,
|
|
||||||
['MESSAGE_ID=' + GNOMESHELL_STARTED_MESSAGE_ID]);
|
|
||||||
} else {
|
|
||||||
log('GNOME Shell started at ' + _startDate);
|
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
@ -28,6 +28,12 @@
|
|||||||
#include <meta/meta-shaped-texture.h>
|
#include <meta/meta-shaped-texture.h>
|
||||||
#include <meta/meta-cursor-tracker.h>
|
#include <meta/meta-cursor-tracker.h>
|
||||||
|
|
||||||
|
#ifdef HAVE_SYSTEMD
|
||||||
|
#include <systemd/sd-journal.h>
|
||||||
|
#include <errno.h>
|
||||||
|
#include <unistd.h>
|
||||||
|
#endif
|
||||||
|
|
||||||
/* Memory report bits */
|
/* Memory report bits */
|
||||||
#ifdef HAVE_MALLINFO
|
#ifdef HAVE_MALLINFO
|
||||||
#include <malloc.h>
|
#include <malloc.h>
|
||||||
@ -1298,6 +1304,52 @@ shell_global_reexec_self (ShellGlobal *global)
|
|||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* shell_global_log_structured:
|
||||||
|
* @message: A message to print
|
||||||
|
* @keys: (allow-none) (array zero-terminated=1) (element-type utf8): Optional structured data
|
||||||
|
*
|
||||||
|
* Log structured data in an operating-system specific fashion. The
|
||||||
|
* parameter @opts should be an array of UTF-8 KEY=VALUE strings.
|
||||||
|
* This function does not support binary data. See
|
||||||
|
* http://www.freedesktop.org/software/systemd/man/systemd.journal-fields.html
|
||||||
|
* or more information about fields that can be used on a systemd
|
||||||
|
* system.
|
||||||
|
*
|
||||||
|
*/
|
||||||
|
void
|
||||||
|
shell_global_log_structured (const char *message,
|
||||||
|
const char *const *keys)
|
||||||
|
{
|
||||||
|
#ifdef HAVE_SYSTEMD
|
||||||
|
const char *const*iter;
|
||||||
|
char *msgkey;
|
||||||
|
guint i, n_opts;
|
||||||
|
struct iovec *iovs;
|
||||||
|
|
||||||
|
for (n_opts = 0, iter = keys; *iter; iter++, n_opts++)
|
||||||
|
;
|
||||||
|
|
||||||
|
n_opts++; /* Add one for MESSAGE= */
|
||||||
|
iovs = g_alloca (sizeof (struct iovec) * n_opts);
|
||||||
|
|
||||||
|
for (i = 0, iter = keys; *iter; iter++, i++) {
|
||||||
|
iovs[i].iov_base = (char*)keys[i];
|
||||||
|
iovs[i].iov_len = strlen (keys[i]);
|
||||||
|
}
|
||||||
|
g_assert(i == n_opts-1);
|
||||||
|
msgkey = g_strconcat ("MESSAGE=", message, NULL);
|
||||||
|
iovs[i].iov_base = msgkey;
|
||||||
|
iovs[i].iov_len = strlen (msgkey);
|
||||||
|
|
||||||
|
// The code location isn't useful since we're wrapping
|
||||||
|
sd_journal_sendv (iovs, n_opts);
|
||||||
|
g_free (msgkey);
|
||||||
|
#else
|
||||||
|
g_print ("%s\n", message);
|
||||||
|
#endif
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* shell_global_notify_error:
|
* shell_global_notify_error:
|
||||||
* @global: a #ShellGlobal
|
* @global: a #ShellGlobal
|
||||||
|
@ -124,6 +124,9 @@ void shell_global_init_xdnd (ShellGlobal *global);
|
|||||||
|
|
||||||
void shell_global_reexec_self (ShellGlobal *global);
|
void shell_global_reexec_self (ShellGlobal *global);
|
||||||
|
|
||||||
|
void shell_global_log_structured (const char *message,
|
||||||
|
const char *const *keys);
|
||||||
|
|
||||||
const char * shell_global_get_session_mode (ShellGlobal *global);
|
const char * shell_global_get_session_mode (ShellGlobal *global);
|
||||||
|
|
||||||
void shell_global_set_runtime_state (ShellGlobal *global,
|
void shell_global_set_runtime_state (ShellGlobal *global,
|
||||||
|
Loading…
Reference in New Issue
Block a user