brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

screenshot: Fix stripping suffix from relative filename

Browse Source 
String.prototype.substr() doesn't support a negative length value
(to subtract from the full length), so we end up with a filename
of '' when hitting that code paths (a relative filename with '.png'
suffix).

Fix this by switching to String.prototype.replace() instead.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2091
This commit is contained in:
Florian Müllner 2020-01-10 19:26:05 +01:00
parent a8dcfa4656
commit 4c6a0678ff
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
js/ui/screenshot.js
View File

@ -65,8 +65,7 @@ var ScreenshotService = class {
} }
*_resolveRelativeFilename(filename) { *_resolveRelativeFilename(filename) {
if (GLib.str_has_suffix(filename, '.png')) filename = filename.replace(/\.png$/, '');
filename = filename.substr(0, -4);
let path = [ let path = [
GLib.get_user_special_dir(GLib.UserDirectory.DIRECTORY_PICTURES), GLib.get_user_special_dir(GLib.UserDirectory.DIRECTORY_PICTURES),