brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

js: Cleanup usage of StScrollView

Browse Source 
Whilst you *can* use add_actor() with ScrollView, it's more idiomatic to
work on :child

Cleanup a few extras along the way

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3010>
This commit is contained in:
Zander Brown
2023-11-07 10:47:14 +00:00
committed by Marge Bot
parent c72742486f
commit 49cca32ca5
12 changed files with 55 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
js/ui/lookingGlass.js
View File

@@ -162,9 +162,8 @@ const Notebook = GObject.registerClass({
labelBox.add_child(label);
this.tabControls.add_child(labelBox);
let scrollview = new St.ScrollView({y_expand: true});
scrollview.get_hscroll_bar().hide();
scrollview.add_child(child);
const scrollview = new St.ScrollView({y_expand: true, child});
scrollview.hscroll.hide();
const tabData = {
child,
@@ -395,7 +394,7 @@ class ObjInspector extends St.ScrollView {
this._parentList = [];
this.get_hscroll_bar().hide();
this.hscroll.hide();
this._container = new St.BoxLayout({
name: 'LookingGlassPropertyInspector',
style_class: 'lg-dialog',
@@ -403,7 +402,7 @@ class ObjInspector extends St.ScrollView {
x_expand: true,
y_expand: true,
});
this.add_child(this._container);
this.child = this._container;
this._lookingGlass = lookingGlass;
}