brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs: Conform to coding style in HACKING guide

Browse Source 
The document is supposed to outline our best practices on the
javascript side, so make sure the code snippets actually conform
to the enforced style.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/919
This commit is contained in:
Florian Müllner 2019-11-25 20:17:38 +01:00
parent 9dc85d76d9
commit 45fe925a1b
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
HACKING.md
View File

@ -29,9 +29,8 @@ what to do.
bar = do_thing(b); bar = do_thing(b);
if (var == 5) { if (var == 5) {
for (let i = 0; i < 10; i++) { for (let i = 0; i < 10; i++)
print(i); print(i);
}
} else { } else {
print(20); print(20);
} }
@ -102,9 +101,8 @@ under the imports:
Always use either `const` or `let` when defining a variable. Always use either `const` or `let` when defining a variable.
```javascript ```javascript
// Iterating over an array // Iterating over an array
for (let i = 0; i < arr.length; ++i) { for (let i = 0; i < arr.length; ++i)
let item = arr[i]; let item = arr[i];
}
// Iterating over an object's properties // Iterating over an object's properties
for (let prop in someobj) { for (let prop in someobj) {
@ -252,7 +250,7 @@ variable that can be captured in closures.
All closures should be wrapped with Function.prototype.bind or use arrow All closures should be wrapped with Function.prototype.bind or use arrow
notation. notation.
```javascript ```javascript
let closure1 = () => { this._fnorbate(); }; let closure1 = () => this._fnorbate();
let closure2 = this._fnorbate.bind(this); let closure2 = this._fnorbate.bind(this);
``` ```