dash: destroy items's child before tooltip

Destroy the DashItemContainer's child from the same handler as the tooltip. This
will prevent invalid reads when the item is destroyed while its quicklist is
still open.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/781


(cherry picked from commit ff2fbf5ae4)
This commit is contained in:
Andrea Azzarone 2018-11-16 18:31:56 +00:00 committed by Florian Müllner
parent ae0461fd60
commit 45b4495886

View File

@ -52,6 +52,8 @@ var DashItemContainer = new Lang.Class({
this.animatingOut = false; this.animatingOut = false;
this.connect('destroy', () => { this.connect('destroy', () => {
if (this.child != null)
this.child.destroy();
this.label.destroy(); this.label.destroy();
}); });
}, },