From 432c2863abcc754cbaf84b26b27cc08cb7f335c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Fri, 2 Oct 2020 17:10:42 +0200 Subject: [PATCH] dash: Restore icon's expected DND behavior Commit ff3d32dd186fa added a custom DashIcon subclass that disables all DND methods from ancestors, including canceling the context menu timeout and emitting the overview's item-drag-begin signal. All we want is opting out of the parent's scale-and-fade behavior, so override those methods instead. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3209 --- js/ui/dash.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/ui/dash.js b/js/ui/dash.js index dbddd996f..7e4457e5e 100644 --- a/js/ui/dash.js +++ b/js/ui/dash.js @@ -31,11 +31,11 @@ class DashIcon extends AppDisplay.AppIcon { }); } - // Disable all DnD methods - _onDragBegin() { + // Disable scale-n-fade methods used during DND by parent + scaleAndFade() { } - _onDragEnd() { + undoScaleAndFade() { } handleDragOver() {