brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dash: destroy items's child before tooltip

Browse Source 
Destroy the DashItemContainer's child from the same handler as the tooltip. This
will prevent invalid reads when the item is destroyed while its quicklist is
still open.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/781

(cherry picked from commit ff2fbf5ae4)
This commit is contained in:
Andrea Azzarone 2018-11-16 18:31:56 +00:00 committed by Marco Trevisan (Treviño)
parent d53bd98532
commit 420c1cbfd1
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/dash.js
View File

@ -52,6 +52,8 @@ var DashItemContainer = new Lang.Class({
this.animatingOut = false; this.animatingOut = false;
this.connect('destroy', () => { this.connect('destroy', () => {
if (this.child != null)
this.child.destroy();
this.label.destroy(); this.label.destroy();
}); });
}, },