brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

calendar-server: Fix double-free detection abort

Browse Source 
app_notify_events_added uses an intermediate builder to construct an
array that is then added to the main variant using g_variant_builder_add
which should clear the intermediate, but doesn't due to the way it is
passed: by value, rather than as a pointer.

This was debugged with the help of Eduardo Habkost, who believes it
works on x86 due to big structs being passed as pointers.

Fixed: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3440
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1848>
This commit is contained in:
Gustavo Noronha Silva 2021-05-18 15:28:43 -03:00
parent d9239e2cee
commit 404ca91941
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/calendar-server/gnome-shell-calendar-server.c
View File

@ -381,8 +381,7 @@ app_notify_events_added (App *app)
(gboolean) appt->is_all_day, (gboolean) appt->is_all_day,
(gint64) start_time, (gint64) start_time,
(gint64) end_time, (gint64) end_time,
extras_builder); &extras_builder);
g_variant_builder_clear (&extras_builder);
} }
} }