brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

modalDialog: Remove timestamp parameter from open()

Browse Source 
It is now unused.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3195>
This commit is contained in:
Florian Müllner 2024-02-17 00:07:36 +01:00 committed by Marge Bot
parent 0ae285cc82
commit 3f72a04a1b
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/components/networkAgent.js
View File

@ -648,7 +648,7 @@ class VPNRequestHandler extends Signals.EventEmitter {
if (contentOverride && contentOverride.secrets.length) { if (contentOverride && contentOverride.secrets.length) {
// Only show the dialog if we actually have something to ask // Only show the dialog if we actually have something to ask
this._shellDialog = new NetworkSecretDialog(this._agent, this._requestId, this._connection, 'vpn', [], this._flags, contentOverride); this._shellDialog = new NetworkSecretDialog(this._agent, this._requestId, this._connection, 'vpn', [], this._flags, contentOverride);
this._shellDialog.open(global.get_current_time()); this._shellDialog.open();
} else { } else {
this._agent.respond(this._requestId, Shell.NetworkAgentResponse.CONFIRMED); this._agent.respond(this._requestId, Shell.NetworkAgentResponse.CONFIRMED);
this.destroy(); this.destroy();
@ -818,7 +818,7 @@ class NetworkAgent {
delete this._dialogs[requestId]; delete this._dialogs[requestId];
}); });
this._dialogs[requestId] = dialog; this._dialogs[requestId] = dialog;
dialog.open(global.get_current_time()); dialog.open();
} }
_cancelRequest(agent, requestId) { _cancelRequest(agent, requestId) {

2
js/ui/components/polkitAgent.js
View File

@ -193,7 +193,7 @@ const AuthenticationDialog = GObject.registerClass({
_ensureOpen() { _ensureOpen() {
// NOTE: ModalDialog.open() is safe to call if the dialog is // NOTE: ModalDialog.open() is safe to call if the dialog is
// already open - it just returns true without side-effects // already open - it just returns true without side-effects
if (!this.open(global.get_current_time())) { if (!this.open()) {
// This can fail if e.g. unable to get input grab // This can fail if e.g. unable to get input grab
// //
// In an ideal world this wouldn't happen (because the // In an ideal world this wouldn't happen (because the

4
js/ui/endSessionDialog.js
View File

@ -708,7 +708,7 @@ class EndSessionDialog extends ModalDialog.ModalDialog {
} }
async OpenAsync(parameters, invocation) { async OpenAsync(parameters, invocation) {
let [type, timestamp, totalSecondsToStayOpen, inhibitorObjectPaths] = parameters; let [type, timestamp_, totalSecondsToStayOpen, inhibitorObjectPaths] = parameters;
this._totalSecondsToStayOpen = totalSecondsToStayOpen; this._totalSecondsToStayOpen = totalSecondsToStayOpen;
this._type = type; this._type = type;
@ -774,7 +774,7 @@ class EndSessionDialog extends ModalDialog.ModalDialog {
this._updateButtons(); this._updateButtons();
if (!this.open(timestamp)) { if (!this.open()) {
invocation.return_error_literal( invocation.return_error_literal(
ModalDialogError.GRAB_FAILED, ModalDialogError.GRAB_FAILED,
'Cannot grab pointer and keyboard'); 'Cannot grab pointer and keyboard');

2
js/ui/extensionDownloader.js
View File

@ -66,7 +66,7 @@ export async function installExtension(uuid, invocation) {
} }
const dialog = new InstallExtensionDialog(uuid, info, invocation); const dialog = new InstallExtensionDialog(uuid, info, invocation);
dialog.open(global.get_current_time()); dialog.open();
} }
/** /**

2
js/ui/modalDialog.js
View File

@ -171,7 +171,7 @@ export const ModalDialog = GObject.registerClass({
() => (this._initialKeyFocus = null), this); () => (this._initialKeyFocus = null), this);
} }
open(_timestamp) { open() {
if (this.state === State.OPENED || this.state === State.OPENING) if (this.state === State.OPENED || this.state === State.OPENING)
return true; return true;