brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dnd: Fix used of undefined variables

Browse Source 
The variables this._yOffset and this._xOffset are included in the
drop coordinates, but as far as I can tell never defined.  Looking
back on the commit that introduced this code, they weren't removed
from anywhere else either.

The drop coordinates seem correct without them, so just delete them.
This commit is contained in:
Colin Walters 2009-08-06 19:34:12 -04:00
parent ccafa53bd6
commit 3c87d76741
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/dnd.js
View File

@ -133,8 +133,8 @@ _Draggable.prototype = {
// We can check the return value of the function and break the loop if it's true if we don't want // We can check the return value of the function and break the loop if it's true if we don't want
// to continue checking the parents. // to continue checking the parents.
target._delegate.handleDragOver(this.actor._delegate, actor, target._delegate.handleDragOver(this.actor._delegate, actor,
(stageX + this._dragOffsetX + this._xOffset - targX) / target.scale_x, (stageX + this._dragOffsetX - targX) / target.scale_x,
(stageY + this._dragOffsetY + this._yOffset - targY) / target.scale_y, (stageY + this._dragOffsetY - targY) / target.scale_y,
event.get_time()); event.get_time());
} }
target = target.get_parent(); target = target.get_parent();
@ -163,8 +163,8 @@ _Draggable.prototype = {
if (target._delegate && target._delegate.acceptDrop) { if (target._delegate && target._delegate.acceptDrop) {
let [targX, targY] = target.get_transformed_position(); let [targX, targY] = target.get_transformed_position();
if (target._delegate.acceptDrop(this.actor._delegate, actor, if (target._delegate.acceptDrop(this.actor._delegate, actor,
(dropX + this._xOffset - targX) / target.scale_x, (dropX - targX) / target.scale_x,
(dropY + this._yOffset - targY) / target.scale_y, (dropY - targY) / target.scale_y,
event.get_time())) { event.get_time())) {
// If it accepted the drop without taking the actor, // If it accepted the drop without taking the actor,
// destroy it. // destroy it.