brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SwitcherPopup: Check for type using constructor

Browse Source 
Classes that are sub-classes of GObject don't use a constructor per se, so we
can't check for new.target (as this is undefined) in _init.

Then compare the current constructor name instead.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/503
This commit is contained in:
Marco Trevisan (Treviño) 2019-04-18 15:50:49 -05:00
parent a63ba61194
commit 3c54e863e6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/switcherPopup.js
View File

@ -33,8 +33,8 @@ function primaryModifier(mask) {
var SwitcherPopup = GObject.registerClass( var SwitcherPopup = GObject.registerClass(
class SwitcherPopup extends St.Widget { class SwitcherPopup extends St.Widget {
_init(items) { _init(items) {
if (new.target === SwitcherPopup) if (this.constructor.name === SwitcherPopup.prototype.constructor.name)
throw new TypeError('Cannot instantiate abstract class ' + new.target.name); throw new TypeError(`Cannot instantiate abstract class ${this.constructor.name}`);
super._init({ style_class: 'switcher-popup', super._init({ style_class: 'switcher-popup',
reactive: true, reactive: true,