From 3be489c69e4980bca8aa85808ed6628b69551071 Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Fri, 22 Mar 2013 15:01:29 -0400 Subject: [PATCH] background: always add content to cache We currently only add the first instance of a background to the cache. This means if the actor associated with that background is destroyed, the content will be evicted and it will need to get reloaded, even if it's already loaded on another actor. This commit ensures every content gets added to the cache. https://bugzilla.gnome.org/show_bug.cgi?id=696157 --- js/ui/background.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/js/ui/background.js b/js/ui/background.js index 0672dd14e..aa238e741 100644 --- a/js/ui/background.js +++ b/js/ui/background.js @@ -84,10 +84,10 @@ const BackgroundCache = new Lang.Class({ } else { content.load_gradient(params.shadingType, params.color, params.secondColor); } - - this._patterns.push(content); } + this._patterns.push(content); + return content; }, @@ -165,6 +165,8 @@ const BackgroundCache = new Lang.Class({ if (params.cancellable && params.cancellable.is_cancelled()) content = null; + else + this._images.push(content); if (params.onFinished) params.onFinished(content);