From 3ad2baede0032ca8b46c2bf389a8b5dd6a6ba1fc Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Fri, 29 May 2020 17:12:09 +0200 Subject: [PATCH] padOsd: Apply specific CSS to Button/Leader SVG classes Applying a fill operation on the Leader line path seems to close it, resulting in filled polygon. Bug or not this is not the intended result here, we can do less ambiguously by not specifying the fill CSS property to the Leader class. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2570 https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1290 --- js/ui/padOsd.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/js/ui/padOsd.js b/js/ui/padOsd.js index b767ee85c..94f7fa9b2 100644 --- a/js/ui/padOsd.js +++ b/js/ui/padOsd.js @@ -383,10 +383,8 @@ var PadDiagram = GObject.registerClass({ for (let i = 0; i < this._activeButtons.length; i++) { let ch = String.fromCharCode('A'.charCodeAt() + this._activeButtons[i]); - css += '.%s {'.format(ch); - css += ' stroke: %s !important;'.format(ACTIVE_COLOR); - css += ' fill: %s !important;'.format(ACTIVE_COLOR); - css += '}'; + css += '.%s.Leader { stroke: %s !important; }'.format(ch, ACTIVE_COLOR); + css += '.%s.Button { stroke: %s !important; fill: %s !important; }'.format(ch, ACTIVE_COLOR, ACTIVE_COLOR); } return css;