From 3a13e7484a95c5ebd7b9f47aad0d4cf8bcb31923 Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Sun, 28 Jul 2013 16:15:43 -0400 Subject: [PATCH] authPrompt: don't muck with cancelButton in onAskQuestion onAskQuestion has this code: if (this.verifyingUser) this.cancelButton.show(); else this.cancelButton.hide(); but onAskQuestion can only be called when this.verifyingUser is true. Also, cancelButton is public, and it only ever otherwise gets hidden from callers. This commit drops mucking with cancelButton visibility, leaving it entirely up to the callers to deal with. https://bugzilla.gnome.org/show_bug.cgi?id=683437 --- js/gdm/authPrompt.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/js/gdm/authPrompt.js b/js/gdm/authPrompt.js index 6b2480b1b..f287b9e78 100644 --- a/js/gdm/authPrompt.js +++ b/js/gdm/authPrompt.js @@ -195,11 +195,6 @@ const AuthPrompt = new Lang.Class({ this.setPasswordChar(passwordChar); this.setQuestion(question); - if (this.verifyingUser) - this.cancelButton.show(); - else - this.cancelButton.hide(); - if (passwordChar) { if (this._userVerifier.reauthenticating) this.nextButton.label = _("Unlock");