brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Scroll to bottom when pushing a result

Browse Source 
This makes the evaluator significantly more useful past a few
results.

https://bugzilla.gnome.org/show_bug.cgi?id=597919
This commit is contained in:
Colin Walters 2009-10-08 20:11:45 -04:00
parent aa9c585562
commit 39edf54aa9
1 changed files with 43 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
js/ui/lookingGlass.js
View File

@ -62,10 +62,18 @@ Notebook.prototype = {
scrollview.get_hscroll_bar().hide(); scrollview.get_hscroll_bar().hide();
scrollview.add_actor(child); scrollview.add_actor(child);
this._tabs.push([child, labelBox, scrollview]); let tabData = { child: child,
labelBox: labelBox,
scrollView: scrollview,
_scrollToBottom: false };
this._tabs.push(tabData);
scrollview.hide(); scrollview.hide();
this.actor.add(scrollview, { expand: true }); this.actor.add(scrollview, { expand: true });
let vAdjust = scrollview.vscroll.adjustment;
vAdjust.connect('changed', Lang.bind(this, function () { this._onAdjustScopeChanged(tabData); }));
vAdjust.connect('notify::value', Lang.bind(this, function() { this._onAdjustValueChanged(tabData); }));
if (this._selectedIndex == -1) if (this._selectedIndex == -1)
this.selectIndex(0); this.selectIndex(0);
}, },
@ -73,10 +81,10 @@ Notebook.prototype = {
_unselect: function() { _unselect: function() {
if (this._selectedIndex < 0) if (this._selectedIndex < 0)
return; return;
let [child, labelBox, scrollview] = this._tabs[this._selectedIndex]; let tabData = this._tabs[this._selectedIndex];
labelBox.padding = 2; tabData.labelBox.padding = 2;
labelBox.border = 0; tabData.labelBox.border = 0;
scrollview.hide(); tabData.scrollView.hide();
this._selectedIndex = -1; this._selectedIndex = -1;
}, },
@ -88,12 +96,12 @@ Notebook.prototype = {
this.emit('selection', null); this.emit('selection', null);
return; return;
} }
let [child, labelBox, scrollview] = this._tabs[index]; let tabData = this._tabs[index];
labelBox.padding = 1; tabData.labelBox.padding = 1;
labelBox.border = 1; tabData.labelBox.border = 1;
scrollview.show(); tabData.scrollView.show();
this._selectedIndex = index; this._selectedIndex = index;
this.emit('selection', child); this.emit('selection', tabData.child);
}, },
selectChild: function(child) { selectChild: function(child) {
@ -101,13 +109,32 @@ Notebook.prototype = {
this.selectIndex(-1); this.selectIndex(-1);
else { else {
for (let i = 0; i < this._tabs.length; i++) { for (let i = 0; i < this._tabs.length; i++) {
let [tabChild, labelBox, scrollview] = this._tabs[i]; let tabData = this._tabs[i];
if (tabChild == child) { if (tabData.child == child) {
this.selectIndex(i); this.selectIndex(i);
return; return;
} }
} }
} }
},
scrollToBottom: function(index) {
let tabData = this._tabs[index];
tabData._scrollToBottom = true;
},
_onAdjustValueChanged: function (tabData) {
let vAdjust = tabData.scrollView.vscroll.adjustment;
if (vAdjust.value < (vAdjust.upper - vAdjust.lower - 0.5))
tabData._scrolltoBottom = false;
},
_onAdjustScopeChanged: function (tabData) {
if (!tabData._scrollToBottom)
return;
let vAdjust = tabData.scrollView.vscroll.adjustment;
vAdjust.value = vAdjust.upper - vAdjust.page_size;
} }
} }
Signals.addSignalMethods(Notebook.prototype); Signals.addSignalMethods(Notebook.prototype);
@ -337,6 +364,7 @@ LookingGlass.prototype = {
})); }));
let notebook = new Notebook(); let notebook = new Notebook();
this._notebook = notebook;
this.actor.add(notebook.actor, { expand: true }); this.actor.add(notebook.actor, { expand: true });
let emptyBox = new St.Bin(); let emptyBox = new St.Bin();
@ -466,6 +494,9 @@ LookingGlass.prototype = {
this._offset++; this._offset++;
} }
this._it = obj; this._it = obj;
// Scroll to bottom
this._notebook.scrollToBottom(0);
}, },
_evaluate : function(command) { _evaluate : function(command) {