From 39a3da654d22f6be9ef4e48be101ae0e6d0a5523 Mon Sep 17 00:00:00 2001
From: Sundeep Mediratta <smedius@gmail.com>
Date: Sun, 4 Aug 2024 13:24:17 -0400
Subject: [PATCH] ibusManager: Simplify code and logic for setEngine()

Reword names, functions and refactor code to make code execution logic
simpler to understand.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3439>
---
 js/misc/ibusManager.js | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/js/misc/ibusManager.js b/js/misc/ibusManager.js
index 8d4973564..0462b2d6a 100644
--- a/js/misc/ibusManager.js
+++ b/js/misc/ibusManager.js
@@ -294,18 +294,23 @@ class IBusManager extends Signals.EventEmitter {
 
     async setEngine(id) {
         if (this._oskCompletion)
-            this._preOskEngine = id;
-
-        const isXkb = id.startsWith('xkb:');
-        if (this._oskCompletion && isXkb)
-            return;
-
-        if (this._oskCompletion)
-            await this.setCompletionEnabled(false);
+            await this._maybeUpdateCompletion(id);
         else
             await this._setEngine(id);
     }
 
+    async _maybeUpdateCompletion(id) {
+        if (!this._oskCompletion)
+            return;
+
+        this._preOskEngine = id;
+        const isXkb = id.startsWith('xkb:');
+
+        /* Non xkb engines conflict with completion */
+        if (!isXkb)
+            await this.setCompletionEnabled(false);
+    }
+
     preloadEngines(ids) {
         if (!this._ibus || !this._ready)
             return;