brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shell-camera-monitor: Fix warning about strict aliasing

Browse Source 
Changing type when casting a double pointer is not strictly allowed in
C. In order to fix compilation with `-fstrict-aliasing`, don’t use
`g_clear_pointer()` for clearing this pointer where the type expected by
the destroy notify function does not match the type stored in the
`ShellCameraMonitor` struct.

This introduces no functional changes.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3351>
This commit is contained in:
Philip Withnall 2024-05-28 18:08:27 +01:00 committed by Marge Bot
parent 245d55488b
commit 37e49e8a22
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/shell-camera-monitor.c
View File

@ -298,7 +298,11 @@ shell_camera_monitor_disconnect_core (ShellCameraMonitor *monitor)
g_clear_handle_id (&monitor->delayed_disable_id, g_source_remove);
spa_hook_remove (&monitor->registry_listener);
g_clear_pointer ((struct pw_proxy**) &monitor->registry, pw_proxy_destroy);
if (monitor->registry != NULL)
{
pw_proxy_destroy ((struct pw_proxy *) monitor->registry);
monitor->registry = NULL;
}
spa_hook_remove (&monitor->core_listener);
g_clear_pointer (&monitor->core, pw_core_disconnect);
}