brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dash: Construct the label at init

Browse Source 
Nothing doesn't use a label, so it doesn't make sense to
lazily initialize it.

https://bugzilla.gnome.org/show_bug.cgi?id=685313
This commit is contained in:
Jasper St. Pierre 2012-10-03 02:19:36 -03:00
parent 245e43ea8c
commit 36e5ae4a25
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
js/ui/dash.js
View File

@ -48,7 +48,9 @@ const DashItemContainer = new Lang.Class({
Lang.bind(this, this._allocate)); Lang.bind(this, this._allocate));
this.actor._delegate = this; this.actor._delegate = this;
this.label = null; this.label = new St.Label({ style_class: 'dash-label'});
this.label.hide();
Main.layoutManager.addChrome(this.label);
this.child = null; this.child = null;
this._childScale = 1; this._childScale = 1;
@ -103,9 +105,6 @@ const DashItemContainer = new Lang.Class({
}, },
showLabel: function() { showLabel: function() {
if (this.label == null)
return;
this.label.opacity = 0; this.label.opacity = 0;
this.label.show(); this.label.show();
@ -136,19 +135,10 @@ const DashItemContainer = new Lang.Class({
}, },
setLabelText: function(text) { setLabelText: function(text) {
if (this.label == null) {
this.label = new St.Label({ style_class: 'dash-label'});
Main.layoutManager.addChrome(this.label);
this.label.hide();
}
this.label.set_text(text); this.label.set_text(text);
}, },
hideLabel: function () { hideLabel: function () {
if (this.label == null)
return;
Tweener.addTween(this.label, Tweener.addTween(this.label,
{ opacity: 0, { opacity: 0,
time: DASH_ITEM_LABEL_HIDE_TIME, time: DASH_ITEM_LABEL_HIDE_TIME,