From 35ead0422cb353766f8c5a823fa943a8498ef2f1 Mon Sep 17 00:00:00 2001 From: Jerome Brenier Date: Thu, 10 Apr 2025 20:04:22 +0200 Subject: [PATCH] magnifier : Fix delayed variables checking A type-safe comparision against null can be incorrectly positive with never initialized variables (undefined). As spotted in https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3688#note_2407551, allowing for type coercion avoids this situation. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7854 Part-of: --- js/ui/magnifier.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/magnifier.js b/js/ui/magnifier.js index 017451cc3..3b5c011a7 100644 --- a/js/ui/magnifier.js +++ b/js/ui/magnifier.js @@ -1280,7 +1280,7 @@ class ZoomRegion { this._clearScrollContentsTimer(); this._scrollContentsTimerId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, POINTER_REST_TIME, () => { this._followingCursor = false; - if (this._xDelayed !== null && this._yDelayed !== null) { + if (this._xDelayed != null && this._yDelayed != null) { this._scrollContentsToDelayed(this._xDelayed, this._yDelayed); this._xDelayed = null; this._yDelayed = null;