From 31b12635d1d97f4f709599138e0a41248398012a Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Wed, 23 Mar 2011 16:05:38 -0400 Subject: [PATCH] messageTray: fix clicking on links again The change to make Notification an StButton (06d2c0af, bug 642978) broke links, because the link actor would ignore the button-press-event, allowing the notification actor to receive it and get a pointer grab, and so the link actor would never see the button-release-event. Fix that by accepting and discarding the button-press-event. https://bugzilla.gnome.org/show_bug.cgi?id=645613 --- js/ui/messageTray.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index f95180167..f592f4849 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -108,6 +108,12 @@ URLHighlighter.prototype = { } this.setMarkup(text, allowMarkup); + this.actor.connect('button-press-event', function() { + // Keep Notification.actor from seeing this and taking + // a pointer grab, which would block our button-release-event + // handler + return true; + }); this.actor.connect('button-release-event', Lang.bind(this, function (actor, event) { let urlId = this._findUrlAtPos(event); if (urlId != -1) {