From 317f0f5fe063356e961006fd75a9c8d9a38f47ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 1 Sep 2021 21:18:42 +0200 Subject: [PATCH] introspect: Use MetaContext:unsafe-mode instead of setting The property was added precisely for this purpose, except that its name isn't tied to the introspect API. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3943 Part-of: --- js/misc/introspect.js | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/js/misc/introspect.js b/js/misc/introspect.js index 3cb021cb1..8e469fbea 100644 --- a/js/misc/introspect.js +++ b/js/misc/introspect.js @@ -1,8 +1,6 @@ /* exported IntrospectService */ const { Gio, GLib, Meta, Shell, St } = imports.gi; -const INTROSPECT_SCHEMA = 'org.gnome.shell'; -const INTROSPECT_KEY = 'introspect'; const APP_ALLOWLIST = [ 'org.freedesktop.impl.portal.desktop.gtk', 'org.freedesktop.impl.portal.desktop.gnome', @@ -36,10 +34,6 @@ var IntrospectService = class { this._syncRunningApplications(); }); - this._introspectSettings = new Gio.Settings({ - schema_id: INTROSPECT_SCHEMA, - }); - let tracker = Shell.WindowTracker.get_default(); tracker.connect('notify::focus-app', () => { @@ -73,10 +67,6 @@ var IntrospectService = class { return app.get_windows().some(w => w.transient_for == null); } - _isIntrospectEnabled() { - return this._introspectSettings.get_boolean(INTROSPECT_KEY); - } - _isSenderAllowed(sender) { return [...this._allowlistMap.values()].includes(sender); } @@ -138,7 +128,7 @@ var IntrospectService = class { } _checkInvocation(invocation) { - if (this._isIntrospectEnabled()) + if (global.context.unsafe_mode) return; if (this._isSenderAllowed(invocation.get_sender()))