brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

status/network: Fix error notification for wireguard

Browse Source 
The function is a handler for the `notify::state` handler, so
the state and reason parameters used in the checks are always
undefined.

In addition, `DEACTIVATED` is not (just) a failure state. We
clearly don't want to complain about a failed connection when
the change happened on request of the user.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2406>
This commit is contained in:
Florian Müllner 2022-08-05 23:21:21 +02:00
parent 44f0a9560c
commit 3113e6ee21
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/ui/status/network.js
View File

@ -1477,9 +1477,13 @@ var NMWireguardItem = class extends NMConnectionItem {
} }
} }
_connectionStateChanged(ac, newstate, reason) { _connectionStateChanged() {
if (newstate === NM.ActiveConnectionState.DEACTIVATED && const state = this._activeConnection?.get_state();
reason !== NM.ActiveConnectionStateReason.NO_SECRETS) const reason = this._activeConnection?.get_state_reason();
if (state === NM.ActiveConnectionState.DEACTIVATED &&
reason !== NM.ActiveConnectionStateReason.NO_SECRETS &&
reason !== NM.ActiveConnectionStateReason.USER_DISCONNECTED)
this.emit('activation-failed'); this.emit('activation-failed');
this.emit('icon-changed'); this.emit('icon-changed');