brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

WorkspacesView: separate setting the full and the actual geometry

Browse Source 
They are different properties, they deserve different syncs.
Especially because a full allocation cycle sets both anyway, so
we should save some cycles this way.

https://bugzilla.gnome.org/show_bug.cgi?id=729823
This commit is contained in:
Giovanni Campagna 2014-05-08 19:15:19 +02:00
parent 02718357da
commit 309d40a92b
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
js/ui/workspacesView.js
View File

@ -74,12 +74,12 @@ const WorkspacesViewBase = new Lang.Class({
setFullGeometry: function(geom) { setFullGeometry: function(geom) {
this._fullGeometry = geom; this._fullGeometry = geom;
this._syncGeometry(); this._syncFullGeometry();
}, },
setActualGeometry: function(geom) { setActualGeometry: function(geom) {
this._actualGeometry = geom; this._actualGeometry = geom;
this._syncGeometry(); this._syncActualGeometry();
}, },
}); });
@ -127,9 +127,12 @@ const WorkspacesView = new Lang.Class({
this._workspaces[i].setReservedSlot(clone); this._workspaces[i].setReservedSlot(clone);
}, },
_syncGeometry: function() { _syncFullGeometry: function() {
for (let i = 0; i < this._workspaces.length; i++) for (let i = 0; i < this._workspaces.length; i++)
this._workspaces[i].setFullGeometry(this._fullGeometry); this._workspaces[i].setFullGeometry(this._fullGeometry);
},
_syncActualGeometry: function() {
for (let i = 0; i < this._workspaces.length; i++) for (let i = 0; i < this._workspaces.length; i++)
this._workspaces[i].setActualGeometry(this._actualGeometry); this._workspaces[i].setActualGeometry(this._actualGeometry);
}, },
@ -260,10 +263,12 @@ const WorkspacesView = new Lang.Class({
} }
} }
if (this._fullGeometry) if (this._fullGeometry) {
this._updateWorkspaceActors(false); this._updateWorkspaceActors(false);
this._syncFullGeometry();
this._syncGeometry(); }
if (this._actualGeometry)
this._syncActualGeometry();
}, },
_activeWorkspaceChanged: function(wm, from, to, direction) { _activeWorkspaceChanged: function(wm, from, to, direction) {
@ -352,8 +357,11 @@ const ExtraWorkspaceView = new Lang.Class({
this._workspace.setReservedSlot(clone); this._workspace.setReservedSlot(clone);
}, },
_syncGeometry: function() { _syncFullGeometry: function() {
this._workspace.setFullGeometry(this._fullGeometry); this._workspace.setFullGeometry(this._fullGeometry);
},
_syncActualGeometry: function() {
this._workspace.setActualGeometry(this._actualGeometry); this._workspace.setActualGeometry(this._actualGeometry);
}, },