brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cleanup: Mark unused arguments as unused

Browse Source 
This will stop eslint from warning about them, while keeping their
self-documenting benefit.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/627
This commit is contained in:
Florian Müllner
2019-01-31 15:08:10 +01:00
parent 79cf3a6dd0
commit 2f97a1a55d
44 changed files with 110 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/ui/iconGrid.js
View File

@ -71,14 +71,14 @@ class BaseIcon extends St.Bin {
this._iconThemeChangedId = cache.connect('icon-theme-changed', this._onIconThemeChanged.bind(this));
}
vfunc_get_preferred_width(forHeight) {
vfunc_get_preferred_width(_forHeight) {
// Return the actual height to keep the squared aspect
return this.get_preferred_height(-1);
}
// This can be overridden by a subclass, or by the createIcon
// parameter to _init()
createIcon(size) {
createIcon(_size) {
throw new GObject.NotImplementedError(`createIcon in ${this.constructor.name}`);
}
@ -247,7 +247,7 @@ var IconGrid = GObject.registerClass({
child.disconnect(child._iconGridKeyFocusInId);
}
vfunc_get_preferred_width(forHeight) {
vfunc_get_preferred_width(_forHeight) {
if (this._fillParent)
// Ignore all size requests of children and request a size of 0;
// later we'll allocate as many children as fit the parent
@ -797,7 +797,7 @@ var PaginatedIconGrid = GObject.registerClass({
this._childrenPerPage = 0;
}
vfunc_get_preferred_height(forWidth) {
vfunc_get_preferred_height(_forWidth) {
let height = (this._availableHeightPerPageForItems() + this.bottomPadding + this.topPadding) * this._nPages + this._spaceBetweenPages * this._nPages;
return [height, height];
}