From 2d6cf236c4974de17c485b4650447fe673a056a9 Mon Sep 17 00:00:00 2001 From: Yussuf Khalil Date: Sun, 29 Apr 2018 18:03:40 +0200 Subject: [PATCH] perf-tool: Fix default value for --extra-filter While it is theoretically fine to run --perf=hwtest without passing --hwtest, the test will hang in this case because it fails to start gedit. Always append Gedit to the default value for --extra-filter when running the "hwtest" test to make it work fine without --hwtest. --- src/gnome-shell-perf-tool.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gnome-shell-perf-tool.in b/src/gnome-shell-perf-tool.in index b2a4521a3..f4b48f730 100755 --- a/src/gnome-shell-perf-tool.in +++ b/src/gnome-shell-perf-tool.in @@ -347,10 +347,10 @@ if options.perf == None: options.perf = 'core' if options.extra_filter is None: - if options.hwtest: - options.extra_filter = ['Gedit'] - else: - options.extra_filter = [] + options.extra_filter = [] + +if options.perf == 'hwtest': + options.extra_filter.append('Gedit') if args: parser.print_usage()