brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Integer align workspace and pane positioning

Browse Source 
We had previously been leaving the scaled workspace at a non-integral
position which didn't look obviously ugly, but now that we're
constraining the popup pane to the workspace size, we really need
to ensure that we're using integral positions here.

https://bugzilla.gnome.org/show_bug.cgi?id=601854
This commit is contained in:
Colin Walters 2009-11-13 18:51:07 -05:00
parent 1526500079
commit 2c914374e0
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
js/ui/overview.js
View File

@ -148,11 +148,11 @@ Overview.prototype = {
// We divide the screen into an imaginary grid which helps us determine the layout of // We divide the screen into an imaginary grid which helps us determine the layout of
// different visual components. // different visual components.
if (wideScreen) { if (wideScreen) {
displayGridColumnWidth = primary.width / COLUMNS_WIDE_SCREEN; displayGridColumnWidth = Math.floor(primary.width / COLUMNS_WIDE_SCREEN);
displayGridRowHeight = primary.height / ROWS_WIDE_SCREEN; displayGridRowHeight = Math.floor(primary.height / ROWS_WIDE_SCREEN);
} else { } else {
displayGridColumnWidth = primary.width / COLUMNS_REGULAR_SCREEN; displayGridColumnWidth = Math.floor(primary.width / COLUMNS_REGULAR_SCREEN);
displayGridRowHeight = primary.height / ROWS_REGULAR_SCREEN; displayGridRowHeight = Math.floor(primary.height / ROWS_REGULAR_SCREEN);
} }
}, },
@ -174,11 +174,11 @@ Overview.prototype = {
- WORKSPACE_GRID_PADDING * 2; - WORKSPACE_GRID_PADDING * 2;
// We scale the vertical padding by (primary.height / primary.width) // We scale the vertical padding by (primary.height / primary.width)
// so that the workspace preserves its aspect ratio. // so that the workspace preserves its aspect ratio.
this._workspacesHeight = displayGridRowHeight * workspaceRowsUsed this._workspacesHeight = Math.floor(displayGridRowHeight * workspaceRowsUsed
- WORKSPACE_GRID_PADDING * (primary.height / primary.width) * 2; - WORKSPACE_GRID_PADDING * (primary.height / primary.width) * 2);
this._workspacesX = displayGridColumnWidth + WORKSPACE_GRID_PADDING; this._workspacesX = displayGridColumnWidth + WORKSPACE_GRID_PADDING;
this._workspacesY = displayGridRowHeight + WORKSPACE_GRID_PADDING * (primary.height / primary.width); this._workspacesY = Math.floor(displayGridRowHeight + WORKSPACE_GRID_PADDING * (primary.height / primary.width));
this._dash.actor.set_position(0, contentY); this._dash.actor.set_position(0, contentY);
this._dash.actor.set_size(displayGridColumnWidth, contentHeight); this._dash.actor.set_size(displayGridColumnWidth, contentHeight);