From 2bb3aed72982970a39749db0c7a095dafb04cdf4 Mon Sep 17 00:00:00 2001 From: Giovanni Campagna Date: Sat, 8 Feb 2014 14:33:32 +0100 Subject: [PATCH] NetworkMenu: sort connections by name only We don't watch for timestamp changes, and sorting by name keeps the order consistent and predictable. In practice, there should be at most 3 or 4 elements, so the user will always read all them at once and sorting is irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=723570 --- js/ui/status/network.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/js/ui/status/network.js b/js/ui/status/network.js index 5e9d478cf..ff536d072 100644 --- a/js/ui/status/network.js +++ b/js/ui/status/network.js @@ -249,10 +249,7 @@ const NMConnectionSection = new Lang.Class({ }, _connectionSortFunction: function(one, two) { - if (one._timestamp == two._timestamp) - return GLib.utf8_collate(one.get_id(), two.get_id()); - - return two._timestamp - one._timestamp; + return GLib.utf8_collate(one.get_id(), two.get_id()); }, _makeConnectionItem: function(connection) { @@ -1788,7 +1785,6 @@ const NMApplet = new Lang.Class({ let connectionSettings = connection.get_setting_by_name(NetworkManager.SETTING_CONNECTION_SETTING_NAME); connection._type = connectionSettings.type; connection._section = this._ctypes[connection._type] || NMConnectionCategory.INVALID; - connection._timestamp = connectionSettings.timestamp; let section = connection._section;