From 29601b84d4b472530bd1725917478b5b49a73b81 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Wed, 8 Jun 2022 11:28:48 -0300 Subject: [PATCH] appDisplay: Don't update fade effect We'll have to dismantle parts of AppDisplay and BaseAppView in order to introduce navigation arrows in a way that won't drive people insane. Start this dismantling by removing the fade effect. It looks odd for now, since we still set padding to the app grid, but that will change soon too. Part-of: --- js/ui/appDisplay.js | 35 ----------------------------------- 1 file changed, 35 deletions(-) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 0768dee34..3bf9a27e2 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -207,7 +207,6 @@ var BaseAppView = GObject.registerClass({ const scroll = this._scrollView.hscroll; this._adjustment = scroll.adjustment; this._adjustment.connect('notify::value', adj => { - this._updateFade(); const value = adj.value / adj.page_size; this._pageIndicators.setCurrentPosition(value); @@ -386,40 +385,6 @@ var BaseAppView = GObject.registerClass({ effect.extend_fade_area = true; } - _updateFade() { - const { pagePadding } = this._grid.layout_manager; - - if (this._pagesShown) - return; - - if (pagePadding.top === 0 && - pagePadding.right === 0 && - pagePadding.bottom === 0 && - pagePadding.left === 0) - return; - - let hOffset = 0; - let vOffset = 0; - - if ((this._adjustment.value % this._adjustment.page_size) !== 0.0) { - const vertical = this._orientation === Clutter.Orientation.VERTICAL; - - hOffset = vertical ? 0 : Math.max(pagePadding.left, pagePadding.right); - vOffset = vertical ? Math.max(pagePadding.top, pagePadding.bottom) : 0; - - if (hOffset === 0 && vOffset === 0) - return; - } - - this._scrollView.update_fade_effect( - new Clutter.Margin({ - left: hOffset, - right: hOffset, - top: vOffset, - bottom: vOffset, - })); - } - _createGrid() { return new IconGrid.IconGrid({ allow_incomplete_pages: true }); }