brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure G_PARAM_STATIC_STRINGS for all properties

Browse Source 
In `st`, we can do this by using `ST_PARAM_*`. In the other code files,
just use `G_PARAM_STATIC_STRINGS` directly.

This is just a minor convenience to prevent a few unnecessary string
copies.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/646
This commit is contained in:
Niels De Graef
2019-07-25 19:34:19 +02:00
committed by Florian Müllner
parent d360114226
commit 28ab1f4af4
20 changed files with 94 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/shell-keyring-prompt.c
View File

@ -347,7 +347,7 @@ shell_keyring_prompt_class_init (ShellKeyringPromptClass *klass)
*/
g_object_class_install_property (gobject_class, PROP_PASSWORD_VISIBLE,
g_param_spec_boolean ("password-visible", "Password visible", "Password field is visible",
FALSE, G_PARAM_READABLE));
FALSE, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
/**
* ShellKeyringPrompt:confirm-visible:
@ -356,7 +356,7 @@ shell_keyring_prompt_class_init (ShellKeyringPromptClass *klass)
*/
g_object_class_install_property (gobject_class, PROP_CONFIRM_VISIBLE,
g_param_spec_boolean ("confirm-visible", "Confirm visible", "Confirm field is visible",
FALSE, G_PARAM_READABLE));
FALSE, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
/**
* ShellKeyringPrompt:warning-visible:
@ -365,7 +365,7 @@ shell_keyring_prompt_class_init (ShellKeyringPromptClass *klass)
*/
g_object_class_install_property (gobject_class, PROP_WARNING_VISIBLE,
g_param_spec_boolean ("warning-visible", "Warning visible", "Warning is visible",
FALSE, G_PARAM_READABLE));
FALSE, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
/**
* ShellKeyringPrompt:choice-visible:
@ -374,7 +374,7 @@ shell_keyring_prompt_class_init (ShellKeyringPromptClass *klass)
*/
g_object_class_install_property (gobject_class, PROP_CHOICE_VISIBLE,
g_param_spec_boolean ("choice-visible", "Choice visible", "Choice is visible",
FALSE, G_PARAM_READABLE));
FALSE, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
/**
* ShellKeyringPrompt:password-actor:
@ -383,7 +383,7 @@ shell_keyring_prompt_class_init (ShellKeyringPromptClass *klass)
*/
g_object_class_install_property (gobject_class, PROP_PASSWORD_ACTOR,
g_param_spec_object ("password-actor", "Password actor", "Text field for password",
CLUTTER_TYPE_TEXT, G_PARAM_READWRITE));
CLUTTER_TYPE_TEXT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
/**
* ShellKeyringPrompt:confirm-actor:
@ -392,7 +392,7 @@ shell_keyring_prompt_class_init (ShellKeyringPromptClass *klass)
*/
g_object_class_install_property (gobject_class, PROP_CONFIRM_ACTOR,
g_param_spec_object ("confirm-actor", "Confirm actor", "Text field for confirming password",
CLUTTER_TYPE_TEXT, G_PARAM_READWRITE));
CLUTTER_TYPE_TEXT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
signals[SIGNAL_SHOW_PASSWORD] = g_signal_new ("show-password", G_TYPE_FROM_CLASS (klass),
0, 0, NULL, NULL,