brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

St: don't attempt to give focus to non reactive actors

Browse Source 
Non reactive actors don't expect to be interacted with, and thus
should not get keyboard focus.

https://bugzilla.gnome.org/show_bug.cgi?id=619955
This commit is contained in:
Giovanni Campagna
2012-07-18 12:19:55 +02:00
parent a29507e452
commit 26d3b1929e
5 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
js/ui/networkAgent.js
View File

@ -165,7 +165,6 @@ const NetworkSecretDialog = new Lang.Class({
}
this._okButton.button.reactive = valid;
this._okButton.button.can_focus = valid;
},
_onOk: function() {

7
js/ui/popupMenu.js
View File

@ -134,7 +134,6 @@ const PopupBaseMenuItem = new Lang.Class({
this.sensitive = sensitive;
this.actor.reactive = sensitive;
this.actor.can_focus = sensitive;
if (sensitive)
this.actor.remove_style_pseudo_class('insensitive');
@ -773,12 +772,10 @@ const PopupSwitchMenuItem = new Lang.Class({
this._statusLabel.text = text;
this._statusBin.child = this._statusLabel;
this.actor.reactive = false;
this.actor.can_focus = false;
this.actor.accessible_role = Atk.Role.MENU_ITEM;
} else {
this._statusBin.child = this._switch.actor;
this.actor.reactive = true;
this.actor.can_focus = true;
this.actor.accessible_role = Atk.Role.CHECK_MENU_ITEM;
}
this.checkAccessibleState();
@ -1891,7 +1888,7 @@ const RemoteMenu = new Lang.Class({
}));
}
item.actor.reactive = item.actor.can_focus = action.enabled;
item.actor.reactive = action.enabled;
if (action.enabled)
item.actor.remove_style_pseudo_class('insensitive');
else
@ -2027,7 +2024,7 @@ const RemoteMenu = new Lang.Class({
if (action.items.length) {
for (let i = 0; i < action.items.length; i++) {
let item = action.items[i];
item.actor.reactive = item.actor.can_focus = action.enabled;
item.actor.reactive = action.enabled;
if (action.enabled)
item.actor.remove_style_pseudo_class('insensitive');