brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspace, workspacesView: Cleanup animation methods

Browse Source 
Remove Workspace.zoomTo/FromOverview(), they're unused now. Rename
everything up to ControlsManager to prepareToEnter/LeaveOverview(),
since these classes don't run the animation anymore.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1624>
This commit is contained in:
Georges Basile Stavracas Neto
2021-01-02 16:17:17 -03:00
committed by Marge Bot
parent d221215ab6
commit 22f4a6b7f6
4 changed files with 12 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
js/ui/workspacesView.js
View File

@ -130,6 +130,7 @@ class WorkspacesView extends WorkspacesViewBase {
this._switchWorkspaceNotifyId =
global.window_manager.connect('switch-workspace',
this._activeWorkspaceChanged.bind(this));
this._updateVisibility();
}
_getFitAllBox(box, spacing, vertical) {
@ -320,11 +321,7 @@ class WorkspacesView extends WorkspacesViewBase {
return this._workspaces[active];
}
animateToOverview() {
this._updateVisibility();
}
animateFromOverview() {
prepareToLeaveOverview() {
for (let w = 0; w < this._workspaces.length; w++)
this._workspaces[w].prepareToLeaveOverview();
}
@ -487,10 +484,7 @@ class ExtraWorkspaceView extends WorkspacesViewBase {
return this._workspace;
}
animateToOverview() {
}
animateFromOverview() {
prepareToLeaveOverview() {
this._workspace.prepareToLeaveOverview();
}
@ -709,13 +703,10 @@ class WorkspacesDisplay extends St.Widget {
primaryWorkspace.visible = visible;
}
animateToOverview() {
prepareToEnterOverview() {
this.show();
this._updateWorkspacesViews();
for (let i = 0; i < this._workspacesViews.length; i++)
this._workspacesViews[i].animateToOverview();
this._restackedNotifyId =
Main.overview.connect('windows-restacked',
this._onRestacked.bind(this));
@ -726,9 +717,9 @@ class WorkspacesDisplay extends St.Widget {
this._keyPressEventId = global.stage.connect('key-press-event', this._onKeyPressEvent.bind(this));
}
animateFromOverview() {
prepareToLeaveOverview() {
for (let i = 0; i < this._workspacesViews.length; i++)
this._workspacesViews[i].animateFromOverview();
this._workspacesViews[i].prepareToLeaveOverview();
this._leavingOverview = true;
this._updateSwipeTracker();