From 20d99c69cb39eb8d0828aca1bfd75e31a626b443 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Thu, 15 Jul 2021 18:48:34 +0200 Subject: [PATCH] search: Exclude hidden results from keynav Since commit 3fb02843, we no longer skip allocation for results that don't fit the width, and give them a 0x0 allocation instead. That has the unintended side effect of those children now being available to keynav. There are cases where we want 0-sized actors to be part of the focus chain (e.g. FocusTrap), but this isn't one of them, so explicitly exclude 0-sized children from keynav. https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4470 Part-of: --- js/ui/search.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/ui/search.js b/js/ui/search.js index de13d6e01..7300b053e 100644 --- a/js/ui/search.js +++ b/js/ui/search.js @@ -429,6 +429,7 @@ var GridSearchResultsLayout = GObject.registerClass({ childBox.set_size(0, 0); child.allocate(childBox); + child.can_focus = childBox.get_area() > 0; childBox.x1 += childWidth; }