brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid passing 'source' as an argument to Notification::destroy()

Browse Source 
Notification::destroy() now takes 'reason' as an optional argument.
Calling Notification::destroy() directly when connecting to 'destroy'
on Source, as we did before, was inadvertently passing 'source' as an
argument to the function.

https://bugzilla.gnome.org/show_bug.cgi?id=640976
This commit is contained in:
Marina Zhurakhinskaya 2011-01-30 18:08:20 -05:00
parent 6cc4c33b13
commit 20b7d34577
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/ui/messageTray.js
View File

@ -274,7 +274,11 @@ Notification.prototype = {
this._capturedEventId = 0; this._capturedEventId = 0;
this._keyPressId = 0; this._keyPressId = 0;
source.connect('destroy', Lang.bind(this, this.destroy)); source.connect('destroy', Lang.bind(this,
// Avoid passing 'source' as an argument to this.destroy()
function () {
this.destroy();
}));
this.actor = new St.Table({ name: 'notification', this.actor = new St.Table({ name: 'notification',
reactive: true }); reactive: true });