brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AppIcon: Nullify _draggable if available on destruction

Browse Source 
When an AppIcon actor is destroyed we try to unset a non-existent draggable
property.

Fix the typo, doing this even if we're not currently in a drag operation.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/677
This commit is contained in:
Marco Trevisan (Treviño) 2019-08-09 23:30:44 +02:00
parent 35dbc3fcc9
commit 209d332a30
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/ui/appDisplay.js
View File

@ -1897,9 +1897,10 @@ var AppIcon = class AppIcon {
} }
if (this._stateChangedId > 0) if (this._stateChangedId > 0)
this.app.disconnect(this._stateChangedId); this.app.disconnect(this._stateChangedId);
if (this._draggable && this._dragging) { if (this._draggable) {
if (this._dragging)
Main.overview.endItemDrag(this); Main.overview.endItemDrag(this);
this.draggable = null; this._draggable = null;
} }
this._stateChangedId = 0; this._stateChangedId = 0;
this._removeMenuTimeout(); this._removeMenuTimeout();