From 200a9ef1af4d2a9472a3977ab6d6bb7f52593171 Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Sat, 20 Apr 2013 16:57:10 -0400 Subject: [PATCH] app-system: Remove get_tree Make clients construct their own gmenu tree if they need it. https://bugzilla.gnome.org/show_bug.cgi?id=698486 --- js/ui/appDisplay.js | 6 +++--- src/shell-app-system.c | 11 ----------- src/shell-app-system.h | 2 -- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 888267deb..b923f4cf7 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -692,8 +692,7 @@ const AppDisplay = new Lang.Class({ Name: 'AppDisplay', _init: function() { - this._appSystem = Shell.AppSystem.get_default(); - this._appSystem.connect('installed-changed', Lang.bind(this, function() { + Shell.AppSystem.get_default().connect('installed-changed', Lang.bind(this, function() { Main.queueDeferredWork(this._allAppsWorkId); })); Main.overview.connect('showing', Lang.bind(this, function() { @@ -809,7 +808,8 @@ const AppDisplay = new Lang.Class({ view.removeAll(); - let tree = this._appSystem.get_tree(); + let tree = new GMenu.Tree({ menu_basename: "applications.menu" }); + tree.load_sync(); let root = tree.get_root_directory(); let iter = root.iter(); diff --git a/src/shell-app-system.c b/src/shell-app-system.c index 85dd4c2cf..1825e510f 100644 --- a/src/shell-app-system.c +++ b/src/shell-app-system.c @@ -390,17 +390,6 @@ on_apps_tree_changed_cb (GMenuTree *tree, g_signal_emit (self, signals[INSTALLED_CHANGED], 0); } -/** - * shell_app_system_get_tree: - * - * Return Value: (transfer none): The #GMenuTree for apps - */ -GMenuTree * -shell_app_system_get_tree (ShellAppSystem *self) -{ - return self->priv->apps_tree; -} - /** * shell_app_system_get_default: * diff --git a/src/shell-app-system.h b/src/shell-app-system.h index 4305878e7..2fc294c8b 100644 --- a/src/shell-app-system.h +++ b/src/shell-app-system.h @@ -39,8 +39,6 @@ struct _ShellAppSystemClass GType shell_app_system_get_type (void) G_GNUC_CONST; ShellAppSystem *shell_app_system_get_default (void); -GMenuTree *shell_app_system_get_tree (ShellAppSystem *system); - ShellApp *shell_app_system_lookup_app (ShellAppSystem *system, const char *id); ShellApp *shell_app_system_lookup_app_for_path (ShellAppSystem *system,