brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AppDisplay: use global settings object

Browse Source 
We don't need a different GSettings object for each app or
favorite item.

While it practice it does not change much (AddMatch is still
obviously sent out), it minimally reduces the overhead on
changes, and makes for cleaner code.

https://bugzilla.gnome.org/show_bug.cgi?id=746509
This commit is contained in:
Giovanni Campagna 2015-03-20 12:30:57 -07:00
parent 048a14f1f3
commit 1f2e53dd15
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
js/ui/appDisplay.js
View File

@ -366,8 +366,6 @@ const AllView = new Lang.Class({
Extends: BaseAppView, Extends: BaseAppView,
_init: function() { _init: function() {
this._settings = new Gio.Settings({ schema_id: 'org.gnome.shell' });
this.parent({ usePagination: true }, null); this.parent({ usePagination: true }, null);
this._scrollView = new St.ScrollView({ style_class: 'all-apps', this._scrollView = new St.ScrollView({ style_class: 'all-apps',
x_expand: true, x_expand: true,
@ -525,7 +523,7 @@ const AllView = new Lang.Class({
// at least on single-monitor setups. // at least on single-monitor setups.
// This also disables drag-to-launch on multi-monitor setups, // This also disables drag-to-launch on multi-monitor setups,
// but we hope that is not used much. // but we hope that is not used much.
let favoritesWritable = this._settings.is_writable('favorite-apps'); let favoritesWritable = global.settings.is_writable('favorite-apps');
apps.forEach(Lang.bind(this, function(appId) { apps.forEach(Lang.bind(this, function(appId) {
let app = appSys.lookup_app(appId); let app = appSys.lookup_app(appId);
@ -783,8 +781,6 @@ const FrequentView = new Lang.Class({
_init: function() { _init: function() {
this.parent(null, { fillParent: true }); this.parent(null, { fillParent: true });
this._settings = new Gio.Settings({ schema_id: 'org.gnome.shell' });
this.actor = new St.Widget({ style_class: 'frequent-apps', this.actor = new St.Widget({ style_class: 'frequent-apps',
layout_manager: new Clutter.BinLayout(), layout_manager: new Clutter.BinLayout(),
x_expand: true, y_expand: true }); x_expand: true, y_expand: true });
@ -827,7 +823,7 @@ const FrequentView = new Lang.Class({
// at least on single-monitor setups. // at least on single-monitor setups.
// This also disables drag-to-launch on multi-monitor setups, // This also disables drag-to-launch on multi-monitor setups,
// but we hope that is not used much. // but we hope that is not used much.
let favoritesWritable = this._settings.is_writable('favorite-apps'); let favoritesWritable = global.settings.is_writable('favorite-apps');
for (let i = 0; i < mostUsed.length; i++) { for (let i = 0; i < mostUsed.length; i++) {
if (!mostUsed[i].get_app_info().should_show()) if (!mostUsed[i].get_app_info().should_show())
@ -1804,8 +1800,6 @@ const AppIconMenu = new Lang.Class({
this.actor.add_style_class_name('app-well-menu'); this.actor.add_style_class_name('app-well-menu');
this._settings = new Gio.Settings({ schema_id: 'org.gnome.shell' });
// Chain our visibility and lifecycle to that of the source // Chain our visibility and lifecycle to that of the source
source.actor.connect('notify::mapped', Lang.bind(this, function () { source.actor.connect('notify::mapped', Lang.bind(this, function () {
if (!source.actor.mapped) if (!source.actor.mapped)
@ -1867,7 +1861,7 @@ const AppIconMenu = new Lang.Class({
})); }));
} }
let canFavorite = this._settings.is_writable('favorite-apps'); let canFavorite = global.settings.is_writable('favorite-apps');
if (canFavorite) { if (canFavorite) {
this._appendSeparator(); this._appendSeparator();