From 1f22c6681a8a1f97429d9b132021ec6df64b0d5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 17 Jan 2024 05:52:10 +0100 Subject: [PATCH] docs: Expand contribution section in README Provide a link to the relevant handbook section and some guidance for submitting a successful merge request, instead of just throwing two links at the user. Part-of: --- README.md | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 4f3841b18..dba27ce09 100644 --- a/README.md +++ b/README.md @@ -77,8 +77,23 @@ When in doubt, it is better to ask before opening an issue. To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell. -Commit messages should follow the [commit message guidelines][commit-messages]. +It can be useful to first look at the [GNOME handbook][mr-handbook]. +If a change likely requires discussion beyond code review, it is probably better to +open an issue first, or follow the process for [feature requests](#feature-requests). +Otherwise, creating a separate issue is not required. + +The following guidelines will help your change to be successfully merged: + + * Keep the change as small as possible. If you can split it into multiple + merge requests, please do so. + * Use multiple commits. This makes it easier to review and helps to diagnose + bugs in the future. + * Use clear commit messages following the [conventions][commit-messages]. + * Pay attention to the CI results. Merge requests cannot be merged until the + CI passes. + +[mr-handbook]: https://handbook.gnome.org/development/change-submission.html [commit-messages]: docs/commit-messages.md ## License