brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: Port GNOMEversionCompare() test to jasmine

Browse Source 
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3164>
This commit is contained in:
Florian Müllner 2024-01-20 08:00:39 +01:00 committed by Marge Bot
parent 41aa44707a
commit 162c9f0056
2 changed files with 48 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/meson.build
View File

@ -28,6 +28,7 @@ unit_tests = [
'params',
'signalTracker',
'url',
'versionCompare',
]
foreach test : unit_tests
@ -45,18 +46,6 @@ foreach test : unit_tests
workdir: meson.current_source_dir())
endforeach
legacy_tests = [
'versionCompare',
]
foreach test : legacy_tests
test(test, run_test,
args: 'unit/@0@.js'.format(test),
suite: 'unit',
env: unit_testenv,
workdir: meson.current_source_dir())
endforeach
shell_tests = [
{
'name': 'basic',

113
tests/unit/versionCompare.js
View File

@ -1,73 +1,54 @@
// -*- mode: js; js-indent-level: 4; indent-tabs-mode: nil -*-
// Test cases for version comparison
const JsUnit = imports.jsUnit;
import 'resource:///org/gnome/shell/ui/environment.js';
import {GNOMEversionCompare} from 'resource:///org/gnome/shell/misc/util.js';
import * as Util from 'resource:///org/gnome/shell/misc/util.js';
describe('GNOMEversionCompare()', () => {
it('compares matching versions', () => {
expect(GNOMEversionCompare('40', '40')).toBe(0);
});
const tests = [
{
v1: '40',
v2: '40',
res: 0,
},
{
v1: '40',
v2: '42',
res: -1,
},
{
v1: '42',
v2: '40',
res: 1,
},
{
v1: '3.38.0',
v2: '40',
res: -1,
},
{
v1: '40',
v2: '3.38.0',
res: 1,
},
{
v1: '40',
v2: '40.rc',
res: 1,
},
{
v1: '40.alpha.1.1',
v2: '40',
res: -1,
},
{
v1: '40',
v2: '40.alpha.1.1',
res: 1,
},
{
v1: '40.beta',
v2: '40',
res: -1,
},
{
v1: '40.1',
v2: '40',
res: 1,
},
{
v1: '',
v2: '40.alpha',
res: -1,
},
];
it('compares older versions', () => {
expect(GNOMEversionCompare('40', '42')).toBeLessThan(0);
expect(GNOMEversionCompare('40.0', '40.1')).toBeLessThan(0);
});
for (let i = 0; i < tests.length; i++) {
const name = `Test #${i} v1: ${tests[i].v1}, v2: ${tests[i].v2}`;
print(name);
JsUnit.assertEquals(name, Util.GNOMEversionCompare(tests[i].v1, tests[i].v2), tests[i].res);
}
it('compares newer versions', () => {
expect(GNOMEversionCompare('42', '40')).toBeGreaterThan(0);
expect(GNOMEversionCompare('40.1', '40.0')).toBeGreaterThan(0);
});
it('compares legacy versions', () => {
expect(GNOMEversionCompare('3.38.0', '40')).toBeLessThan(0);
expect(GNOMEversionCompare('40', '3.38.0')).toBeGreaterThan(0);
});
it('compares pre-release versions', () => {
expect(GNOMEversionCompare('40.beta', '40')).toBeLessThan(0);
expect(GNOMEversionCompare('40.alpha', '40')).toBeLessThan(0);
expect(GNOMEversionCompare('40.rc', '40')).toBeLessThan(0);
expect(GNOMEversionCompare('40', '40.beta')).toBeGreaterThan(0);
expect(GNOMEversionCompare('40', '40.alpha')).toBeGreaterThan(0);
expect(GNOMEversionCompare('40', '40.rc')).toBeGreaterThan(0);
expect(GNOMEversionCompare('40.alpha', '40.beta')).toBeLessThan(0);
expect(GNOMEversionCompare('40.beta', '40.rc')).toBeLessThan(0);
expect(GNOMEversionCompare('40.rc', '40.0')).toBeLessThan(0);
});
it('compares point-release versions', () => {
expect(GNOMEversionCompare('40.1', '40')).toBeGreaterThan(0);
expect(GNOMEversionCompare('40.alpha.1', '40.alpha')).toBeGreaterThan(0);
expect(GNOMEversionCompare('40.beta.1.1', '40.beta.1')).toBeGreaterThan(0);
expect(GNOMEversionCompare('40', '40.1')).toBeLessThan(0);
expect(GNOMEversionCompare('40.alpha', '40.alpha.1')).toBeLessThan(0);
expect(GNOMEversionCompare('40.beta.1', '40.beta.1.1')).toBeLessThan(0);
});
it('compares empty versions', () => {
expect(GNOMEversionCompare('', '40')).toBeLessThan(0);
});
});