brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't declare global variables

Browse Source 
Fix a typo in panel.js, and ensure that all variables used in
functions are scoped to the block (using let), to avoid polluting
the global namespace.

https://bugzilla.gnome.org/show_bug.cgi?id=643210
This commit is contained in:
Giovanni Campagna 2011-02-24 18:17:05 +01:00
parent e1f33739b0
commit 15ec185be5
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/environment.js
View File

@ -17,7 +17,7 @@ function _patchContainerClass(containerClass) {
// This one is a straightforward mapping of the C method // This one is a straightforward mapping of the C method
containerClass.prototype.child_set = function(actor, props) { containerClass.prototype.child_set = function(actor, props) {
let meta = this.get_child_meta(actor); let meta = this.get_child_meta(actor);
for (prop in props) for (let prop in props)
meta[prop] = props[prop]; meta[prop] = props[prop];
}; };

2
js/ui/panel.js
View File

@ -410,7 +410,7 @@ AppMenuButton.prototype = {
let [minSize, naturalSize] = this._iconBox.get_preferred_height(forWidth); let [minSize, naturalSize] = this._iconBox.get_preferred_height(forWidth);
alloc.min_size = minSize; alloc.min_size = minSize;
alloc.natural_size = naturalSize; alloc.natural_size = naturalSize;
[minSizfe, naturalSize] = this._label.actor.get_preferred_height(forWidth); [minSize, naturalSize] = this._label.actor.get_preferred_height(forWidth);
if (minSize > alloc.min_size) if (minSize > alloc.min_size)
alloc.min_size = minSize; alloc.min_size = minSize;
if (naturalSize > alloc.natural_size) if (naturalSize > alloc.natural_size)

4
js/ui/workspaceThumbnail.js
View File

@ -424,7 +424,7 @@ ThumbnailsBox.prototype = {
this._indicatorY = 0; // only used when _animatingIndicator is true this._indicatorY = 0; // only used when _animatingIndicator is true
this._stateCounts = {}; this._stateCounts = {};
for (key in ThumbnailState) for (let key in ThumbnailState)
this._stateCounts[ThumbnailState[key]] = 0; this._stateCounts[ThumbnailState[key]] = 0;
this._thumbnails = []; this._thumbnails = [];
@ -441,7 +441,7 @@ ThumbnailsBox.prototype = {
this._stateUpdateQueued = false; this._stateUpdateQueued = false;
this._stateCounts = {}; this._stateCounts = {};
for (key in ThumbnailState) for (let key in ThumbnailState)
this._stateCounts[ThumbnailState[key]] = 0; this._stateCounts[ThumbnailState[key]] = 0;
// The "porthole" is the portion of the screen that we show in the workspaces // The "porthole" is the portion of the screen that we show in the workspaces