brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: Stop using braces for single-line arrow functions

Browse Source 
Braces are optional for single-line arrow functions, but there's a
subtle difference:
Without braces, the expression is implicitly used as return value; with
braces, the function returns nothing unless there's an explicit return.

We currently reflect that in our style by only omitting braces when the
function is expected to have a return value, but that's not very obvious,
not an important differentiation to make, and not easy to express in an
automatic rule.

So just omit braces consistently as mandated by gjs' coding style.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/608
This commit is contained in:
Florian Müllner
2019-01-28 01:42:00 +01:00
committed by Georges Basile Stavracas Neto
parent 1398aa6562
commit 14d7897a93
39 changed files with 91 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
js/ui/status/system.js
View File

@ -15,13 +15,13 @@ var AltSwitcher = class {
this._standard.connect('notify::visible', this._sync.bind(this));
if (this._standard instanceof St.Button)
this._standard.connect('clicked',
() => { this._clickAction.release(); });
() => this._clickAction.release());
this._alternate = alternate;
this._alternate.connect('notify::visible', this._sync.bind(this));
if (this._alternate instanceof St.Button)
this._alternate.connect('clicked',
() => { this._clickAction.release(); });
() => this._clickAction.release());
this._capturedEventId = global.stage.connect('captured-event', this._onCapturedEvent.bind(this));
@ -32,7 +32,7 @@ var AltSwitcher = class {
this.actor = new St.Bin();
this.actor.connect('destroy', this._onDestroy.bind(this));
this.actor.connect('notify::mapped', () => { this._flipped = false; });
this.actor.connect('notify::mapped', () => this._flipped = false);
}
_sync() {
@ -117,9 +117,9 @@ var Indicator = class extends PanelMenu.SystemIndicator {
this._createSubMenu();
this._loginScreenItem.connect('notify::visible',
() => { this._updateMultiUser(); });
() => this._updateMultiUser());
this._logoutItem.connect('notify::visible',
() => { this._updateMultiUser(); });
() => this._updateMultiUser());
// Whether shutdown is available or not depends on both lockdown
// settings (disable-log-out) and Polkit policy - the latter doesn't
// notify, so we update the menu item each time the menu opens or
@ -303,13 +303,13 @@ var Indicator = class extends PanelMenu.SystemIndicator {
this._settingsAction.connect('notify::visible',
() => { this._updateActionsVisibility(); });
() => this._updateActionsVisibility());
this._orientationLockAction.connect('notify::visible',
() => { this._updateActionsVisibility(); });
() => this._updateActionsVisibility());
this._lockScreenAction.connect('notify::visible',
() => { this._updateActionsVisibility(); });
() => this._updateActionsVisibility());
this._altSwitcher.actor.connect('notify::visible',
() => { this._updateActionsVisibility(); });
() => this._updateActionsVisibility());
}
_onSettingsClicked() {