From 1158e989134d61f943a6af3828fc0227cc0709c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= Date: Mon, 8 Feb 2021 18:43:16 +0100 Subject: [PATCH] gdm: Increase the verification failed counter once we've a failure Decouple the verification failure count increase from _verificationFailed as there are some cases in which we may want to increase it without emitting a verification-failed signal. Part-of: --- js/gdm/util.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/js/gdm/util.js b/js/gdm/util.js index 969e12668..0a275d50e 100644 --- a/js/gdm/util.js +++ b/js/gdm/util.js @@ -384,6 +384,7 @@ var ShellUserVerifier = class { this._hold.release(); this._queueMessage(_("Authentication error"), MessageType.ERROR); + this._failCounter++; this._verificationFailed(serviceName, false); } @@ -609,7 +610,6 @@ var ShellUserVerifier = class { // Otherwise, when in login mode we allow ALLOWED_FAILURES attempts. // After that, we go back to the welcome screen. - this._failCounter++; let canRetry = retry && this._userName && (this._reauthOnly || this._failCounter < this._settings.get_int(ALLOWED_FAILURES_KEY)); @@ -660,8 +660,10 @@ var ShellUserVerifier = class { // if the password service fails, then cancel everything. // But if, e.g., fingerprint fails, still give // password authentication a chance to succeed - if (this.serviceIsForeground(serviceName)) + if (this.serviceIsForeground(serviceName)) { + this._failCounter++; this._verificationFailed(serviceName, true); + } } }; Signals.addSignalMethods(ShellUserVerifier.prototype);