brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pageIndicators: Redesign and add position-based animation

Browse Source 
Remove setCurrentPage() function, introduce setCurrentPosition() instead,
which allows to have fractional positions.

Make inactive dots smaller, filled and partially transparent, as opposed to
larger and fully opaque active dot. Make dots smaller overall, remove
borders. Interpolate each dot between active and inactive state based on
scroll position.

Make it impossible to "uncheck" the active dot.

Thanks Florian Müllner for parts of the code.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1932

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/843
This commit is contained in:
Alexander Mikhaylenko
2019-11-22 03:24:46 +05:00
parent 9790b0ee5d
commit 109f39afa5
4 changed files with 60 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
js/ui/appDisplay.js
View File

@ -315,6 +315,9 @@ var AllView = GObject.registerClass({
this._scrollView.set_policy(St.PolicyType.NEVER,
St.PolicyType.EXTERNAL);
this._adjustment = this._scrollView.vscroll.adjustment;
this._adjustment.connect('notify::value', adj => {
this._pageIndicators.setCurrentPosition(adj.value / adj.page_size);
});
this._pageIndicators = new PageIndicators.AnimatedPageIndicators();
this._pageIndicators.connect('page-activated',
@ -561,7 +564,7 @@ var AllView = GObject.registerClass({
if (!this.mapped) {
this._adjustment.value = this._grid.getPageY(pageNumber);
this._pageIndicators.setCurrentPage(pageNumber);
this._pageIndicators.setCurrentPosition(pageNumber);
this._grid.currentPage = pageNumber;
return;
}
@ -597,8 +600,6 @@ var AllView = GObject.registerClass({
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
duration: time,
});
this._pageIndicators.setCurrentPage(pageNumber);
}
_diffToPage(pageNumber) {
@ -754,7 +755,7 @@ var AllView = GObject.registerClass({
this._adjustment.value = 0;
this._grid.currentPage = 0;
this._pageIndicators.setNPages(this._grid.nPages());
this._pageIndicators.setCurrentPage(0);
this._pageIndicators.setCurrentPosition(0);
return GLib.SOURCE_REMOVE;
});
}