overview: Move the entry out of the SearchTab into the overview
The entry should be positioned in the center of the overview. This makes that its position can’t be set in the viewSelector without making things overly complicated. Therefore we move the entry to the overview. https://bugzilla.gnome.org/show_bug.cgi?id=682109
This commit is contained in:

committed by
Florian Müllner

parent
b5dc78a968
commit
0ea2d98768
@ -185,7 +185,17 @@ const Overview = new Lang.Class({
|
||||
|
||||
this._shellInfo = new ShellInfo();
|
||||
|
||||
this._viewSelector = new ViewSelector.ViewSelector();
|
||||
this._searchEntry = new St.Entry({ name: 'searchEntry',
|
||||
/* Translators: this is the text displayed
|
||||
in the search entry when no search is
|
||||
active; it should not exceed ~30
|
||||
characters. */
|
||||
hint_text: _("Type to search..."),
|
||||
track_hover: true,
|
||||
can_focus: true });
|
||||
this._group.add_actor(this._searchEntry);
|
||||
|
||||
this._viewSelector = new ViewSelector.ViewSelector(this._searchEntry);
|
||||
this._group.add_actor(this._viewSelector.actor);
|
||||
|
||||
// TODO - recalculate everything when desktop size changes
|
||||
@ -477,10 +487,15 @@ const Overview = new Lang.Class({
|
||||
this._coverPane.set_position(0, contentY);
|
||||
this._coverPane.set_size(primary.width, contentHeight);
|
||||
|
||||
let searchWidth = this._searchEntry.get_width();
|
||||
let searchHeight = this._searchEntry.get_height();
|
||||
let searchX = (primary.width - searchWidth) / 2;
|
||||
let searchY = contentY + this._spacing;
|
||||
|
||||
let dashWidth = Math.round(DASH_SPLIT_FRACTION * primary.width);
|
||||
let viewWidth = primary.width - dashWidth - this._spacing;
|
||||
let viewHeight = contentHeight - 2 * this._spacing;
|
||||
let viewY = contentY + this._spacing;
|
||||
let viewHeight = contentHeight - 2 * this._spacing - searchHeight;
|
||||
let viewY = contentY + this._spacing + searchHeight;
|
||||
let viewX = rtl ? 0 : dashWidth + this._spacing;
|
||||
|
||||
// Set the dash's x position - y is handled by a constraint
|
||||
@ -493,6 +508,7 @@ const Overview = new Lang.Class({
|
||||
}
|
||||
this._dash.actor.set_x(dashX);
|
||||
|
||||
this._searchEntry.set_position(searchX, searchY);
|
||||
this._viewSelector.actor.set_position(viewX, viewY);
|
||||
this._viewSelector.actor.set_size(viewWidth, viewHeight);
|
||||
},
|
||||
|
Reference in New Issue
Block a user