brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

slider: Make clicking anywhere on the slider menu item pass to the slider

Browse Source 
This is a regression from splitting the slider out that never got fixed.
Restore the previous (useful) behavior by adding a public API to the
slider that lets us pass an event through.

https://bugzilla.gnome.org/show_bug.cgi?id=704368
This commit is contained in:
Jasper St. Pierre 2013-06-11 23:39:56 -04:00
parent 73cd595b73
commit 0cee0e08e9
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/ui/slider.js
View File

@ -98,6 +98,10 @@ const Slider = new Lang.Class({
}, },
_startDragging: function(actor, event) { _startDragging: function(actor, event) {
this.startDragging(event);
},
startDragging: function(event) {
if (this._dragging) // don't allow two drags at the same time if (this._dragging) // don't allow two drags at the same time
return false; return false;
@ -112,7 +116,6 @@ const Slider = new Lang.Class({
let absX, absY; let absX, absY;
[absX, absY] = event.get_coords(); [absX, absY] = event.get_coords();
this._moveHandle(absX, absY); this._moveHandle(absX, absY);
return true; return true;
}, },

4
js/ui/status/volume.js
View File

@ -43,6 +43,10 @@ const StreamSlider = new Lang.Class({
this.item.addActor(this._icon, { align: St.Align.MIDDLE }); this.item.addActor(this._icon, { align: St.Align.MIDDLE });
this.item.addActor(this._slider.actor, { expand: true }); this.item.addActor(this._slider.actor, { expand: true });
this.item.actor.connect('button-press-event', Lang.bind(this, function(actor, event) {
this._slider.startDragging(event);
}));
this._stream = null; this._stream = null;
}, },